Fix building with external LLVM#13420
Conversation
|
Starting build on |
|
@Axel-Naumann is a backport of #12153 and this PR possible for a 6.28.xx release? |
|
Build failed on ROOT-ubuntu2004/python3. Failing tests: |
|
Build failed on mac11/noimt. Failing tests: |
vgvassilev
left a comment
There was a problem hiding this comment.
That looks like the fix I imagined. LGTM! Thanks!
hahnjo
left a comment
There was a problem hiding this comment.
Also LGTM and CI builds are happy, so let's merge.
I think that's a good idea. Can you prepare a backport PR against |
I was hoping I would be able to do so before I leave, but unfortunately I had to move and don't have access to my computer for a while... So I wouldn't mind if you give it a go, but it's also not super high priority. |
no worries, here we go: #13443 |
|
Hm, it appears the second commit breaks edit: #13446 |
This Pull request:
Changes or fixes:
Ensure that LLVM is always linked statically. While doing so this fixes #12156 and #12152. Tested with both LLVM 13 and LLVM 16.
Checklist:
This PR fixes #12156 #12152